Authorize your GitHub account to vote.
98
votes
|
Contributors of squashed commits don't get any love
by
I contributed a few days of work to an open source project. It was merged into a sub-branch, that was then squashed and merged by the library's original author to keep a clean git history, erasing my status as a contributor. Now when I send people the library and tell them I'm a contributor, they don't believe me, because I've been reduced to a footnote in a commit message. :( Maybe when a squash and merge is done through the UI at least, the information about who contributed those changes could be tracked.
29 comments bug · merge
|
75
votes
|
Updating base branch in PR does not recalculate files in diff
by
I think there's a bug in your new feature from August 15th. The diff showed 5 file changes but it introduced a lot more. When you revert the merging commit, there are 26 changed files. Causes confusion and headache when investigating. I'd rather not have the feature appear at all, vs. having to solve the mystery of why previously reverted commits are showing up in master.
49 comments bug · pull-requests · diff · parity
|
49
votes
|
OAuth web flow endpoints don't support CORS
by
All of the API v3 endpoints on api.github.com support CORS (https://developer.github.com/v3/#cross-origin-resource-sharing): however, the github.com endpoints involved in creating an OAuth2 access token via the Web Flow, specifically https://github.com/login/oauth/access_token, don't support the OPTIONS method or CORS headers necessary to POST to it and get the access_token back. This is a bug. Denying cross-origin access here doesn't help security, as it is most easily worked around by doing the POST requests through a potentially-insecure third-party open reverse proxy (as implemented using https://cors-anywhere.herokuapp.com/https://github.com/login/oauth/access_token on http://stuartpb.github.io/gistachio/demo.html).
18 comments bug · authentication · API
|
40
votes
|
Pull request "Squash and merge" button changes author details
by
samtools/hts-specs#339 was a pull request consisting of a single commit:
It was merged using the GitHub UI "Squash and merge" button (so that it would be rebased onto the current tip of origin/master) leading to the following commit on the main repository's master:
As expected, the Committer and CommitDate have been altered to reflect the person who pressed the merge button. The AuthorDate has been altered by GitHub to be the same as CommitDate, but this is incorrect — the commit was still originally authored on Friday 14th. The AuthorEmail has been altered by GitHub to be the default email address associated with the @jmarshall GitHub account at the time. This is very incorrect, as I do not use this email address when doing work on samtools/hts-specs. When the "Squash and merge" button is being used to squash several commits from different authors, there is an argument to be had that Author/AuthorDate could be updated in some way (or GitHub could just follow what When the "Squash and merge" button is being used to squash several commits from the same author (so AuthorName and AuthorEmail are the same, which is trivially true when there is only one commit), it is a bug to change the author's listed AuthorName or AuthorEmail.
32 comments bug · pull-requests · merge
|
28
votes
|
Push to PR cannot always reset reviews
by
If a pull request branch is updated via a push (force or otherwise), it should invalidate any approvals submitted via the new review system, because the update could introduce new changes which the previous approvers might not approve. Currently this invalidation does not happen, which means that there is a high risk of these new changes getting merged even though they were never reviewed. This significantly weakens the reliability of the review system. Gerrit is an example of a code review system which handles this correctly: only the reviews on the latest patch set are taken into account. As a result of this approach, Gerrit additionally invalidates disapprovals as well as approvals. There are arguments both for and against that behaviour (and hence whether it should be replicated on GitHub): If someone submits a review of an early version of a PR which requires changes (i.e. a -1 vote), then if that disapproval is not reset when a new version of the PR is pushed, it means that a follow-up re-review from that specific person is required before the PR can be merged. That has one advantage of ensuring that the concerns they expressed are fixed by the new version; however there is a risk that that person may go AWOL and leave the PR blocked forever. In that case, a workaround might be to close the PR and resubmit it. This might seem like an overly noisy approach, but OTOH it might be good to make the process of effectively manually overriding someone's disapproval a noisy operation.
12 comments bug · pull-requests · code review
|
12
votes
|
Cannot create a pull request from a branch name that contains emoji with the "Compare & Pull request" button
by
Normally when I push a branch I'll see a message like this in my Slack: Now if I push a branch called ":shower:" I'll see this instead: And when I go to the home page of my repo it mentions that I pushed branches, but doesn't show the name: Clicking the "Compare & Pull Request" button doesn't work; I have to manually open a PR for the branch the hard way by looking through the list of all my branches and finding the appropriate one. Anyways... I don't know the full extent of this issue (whether it extends to unicode characters in general or not). But I would like if GitHub better-supported emoji names for branches since a picture is worth a thousand words, as they say.
5 comments bug
|
8
votes
|
"Create New File" URLs with "filename" query string parameters don't seem to work quite right
by
What the GUI exposesWhen browsing the source code in a repository, GitHub offers a button that says "Create New File": Clicking on it brings the user to a page that looks something like this: The specific link is as follows:
What we foundThe dotnet/docfx developers discovered that you can use query string parameters to pre-fill some of the values for you.
Specifically, the IssuesThe Goes up a levelWhen
It takes you to a page that looks like this (compare the folder path to what we had above): Workaround 1 breaks "cancel" linkThe DocFX folks also saw this, but they found a workaround: append some dummy path after it like "new", so that it puts you into the same folder. Compare this URL:
However, clicking the encircled "cancel" link takes us to a nonexistent page. See discussion and other details in dotnet/docfx#3156:
Workaround 2 doesn't stick through "cancel" and "back button"So I had the idea that, instead of appending some dummy that doesn't exist, we could try duplicating the last folder in the
That brought me here, and it seemed perfect! "Cancel" worked just fine, bringing me back to the folder that would have contained the file. Then I clicked on my browser's "Back" button (Firefox 65), and: ...darn. It seems to have ignored the path information from the What we really needWhat we need is a supported way to pre-fill some of the information on the "Create New File" page in order to be able to help users contribute incremental, targeted improvements to documentation that can be consumed by a tool.
6 comments bug · ui · file-view · documentation · automation
|
6
votes
|
Disable approval of PRs for anyone who has committed to the branch
by
Currently, the person who opened the PR cannot self-approve it. However someone else can push code to the same branch, approve, and merge (bypassing branch protection meant to require review by another person before merging). We'd love a way to prevent this through Github. We found a probot app which does basically what we want, but it would be nice to not have to host this infrastructure ourselves: https://github.com/Raul6469/self-approve
1 comments bug · pull-requests · workflow · merge · github/feedback
|
5
votes
|
Receive "releases only" notifications for projects that do not contain a release message in their releases
by
Please fix this issue "Without adding a message to the release, it only counts as a "tag" and not as a full release". So I'm not getting "releases" notifications for projects that not include a release messages.
3 comments bug · notifications · releases
|
5
votes
|
Large Markdown or Asciidoctor README are cut off at 512k bytes from repo front pages
by
Minimal synthetic examples:
On the above examples, it can be seen that the README is cut off on the repo main pages at: 00000000031999, which according to The blob view however shows up to the correct value of 00000000063999. Edit: as of 2020-06-04 there was an update, and now the blob view just says "Sorry about that, but we can’t show files that are this big right now.", which I'm fine with as it is a clear result. I'd rather have the cropped readme with a clear warning though. Please either render the full thing, or give a clear warning somewhere that the README is being cut down. I wonder if it's truly not technically feasible to render it somehow, since the corresponding github pages of those websites render fine: https://cirosantilli.com/linux-kernel-module-cheat/ I know this is a dynamic website, but maybe there's a way. Real world examples:
Oh, and the blame unicorns "This page is taking way too long to load": https://github.com/cirosantilli/linux-kernel-module-cheat/blame/d6d7f15c912ed6371c8cf15a93f43488d6fc5efb/README.adoc (archive).
0 comments bug · render · unicorns 🦄
|
5
votes
|
Github search sorting by most starred might be broken.
by
I was just looking at the most starred repos of all time and used the following command: https://github.com/search?o=desc&q=stars%3A%3E0&s=stars&type=Repositories Notice that the first image has both vue and react but the second one doesn't have vue. I refreshed the pages several times and the issue persisted. Checked the console but there was no error. Is it just me or did somebody else also noticed this as well?
2 comments bug · search · sorting
|
5
votes
|
https://api.github.com/user/orgs returns **only** private organizations with opt-in access for OAuth applications with read:org scope
by
This is a bug, and I haven't reported it to Github yet, because, given the caliber of their response to the last eight bugs I've reported to them, I'm certain they're just going to brush me off, misunderstand the issue without reading it, blame me, and deny anything's wrong, and I just do not have the energy to deal with that crap right now. What I have below is the draft of what I would send to GitHub, if I weren't absolutely certain it'd end up in nothing but headaches for me. The issueRequesting a user's organization membership (see the docs) with a personal access token gives you the complete list of all organizations the user is a member of, public or private. This is good. This is what I want. Requesting the same organization membership with a token obtained through an OAuth application returns only the organizations that the user allowed the application access to - not the ones they have private membership to (which are included with a personal access token), and not even the ones their membership is already public for. Considering that part of the dialog when granting access says that the application will be able to read "public and private organization membership" or something like that, I'd say this is pretty messed up. I need API access to all the organizations I'm a member to as they emerge, and I don't want to have to go through the agony of re-approving every organization, to every application. every time I join a new org, just to keep this current.
2 comments bug · API
|
5
votes
|
.tsv file with "Illegal quoting"
by
A .tsv file that contains quotes triggers this error message: However, quotes in .tsv files do not have any special meaning so there cannot be any illegal quoting. I would be very pleased if you can change the .tsv rendering accordingly.
6 comments bug · render
|
4
votes
|
Your web UI cannot handle a mere 100k commit octopus merge
by
If the hanging page is killing your server, feel free to delete that repo while you fix the issue. I didn't think it would be that bad. And Linus called a 66-way merge a Cthulhu merge... too young too naive: https://softwareengineering.stackexchange.com/questions/314215/can-a-git-commit-have-more-than-2-parents/377903#377903 Update 2018-11-15: https://github.com/cirosantilli/test-octopus-100k dit not 500 once for the first time. The head commit with many children took forever but did load after a few minutes! Children did not show on UI though: cirosantilli/test-octopus-100k@8582d01 Update 2019-01-13: OK, now cirosantilli/test-octopus-100k@8582d01 opens, but keeps loading the list of children forever. Update 2019-05: nevermind, unicorn is back after a while of loading. Update 2020-12-04: Pushing 1M failed with "Connection to github.com closed by remote host. fatal: the remote end hung up unexpectedly".
2 comments bug · merge · unicorns 🦄
|
4
votes
|
No :simple-smile: in comments & other emoji issues
by
I have noticed that at the bottom of all GitHub comment boxes there is a GitHub Markdown link that takes the user here: https://guides.github.com/features/mastering-markdown/ If the user scrolls down to the very bottom of the GitHub Mastering Markdown page to "Emoji" there is a link that takes the user to an "Emoji Cheat Sheet" page here: https://www.webpagefx.com/tools/emoji-cheat-sheet/ Issue
Issue
Please resolve this and make this consistent. It will go a LONG way with community building as Emoji's are a standard of communication in the age we live in. Thank you.
1 comments bug · markdown
|
4
votes
|
GitHub's reStructuredText renderer doesn't process links correctly.
by
For example, the following a directory of `reStructuredText <restructuredtext_>`_ files.
.. _restructuredtext: http://docutils.sourceforge.net/rst.html The link should point to
3 comments bug · render
|
4
votes
|
Support Unicode symbols everywhere
by
It’s imposible to use astral (= supplementary) Unicode symbols in comments on GitHub. This is very annoying, since lots of software has bugs with these symbols, and this GitHub bug makes it impossible to write a decent bug report about it. Astral code points range from U+010000 to U+10FFFF. Try U+1D306 TETRAGRAM FOR CENTRE or U+1F4A9 PILE OF POO, for example.
3 comments bug · ui · emoji
|
4
votes
|
Use pushState instead of replaceState when changing tabs in a PR (aka "please don't break the back button")
by
Reproduce:
Expect: Return to the "Discussion" tab.
18 comments bug · pull-requests
|
3
votes
|
Relative links inside list items in the repository root page in README.md markdown are missing blob/master from URL
by
There is a bug in parsing two the same links in different ways.
Result: In the list expected the same link as in regular text block. It will show a bug on using links from repository root page in README.md file.
3 comments bug · markdown
|
3
votes
|
Profile: Allow non-ASCII characters in url/email
by
0 comments bug · internationalization
|
2
votes
|
Discussion notifications links not populated in API request
by
When a notification comes from discussions section, the API doesn't populate the link correctly and it's null when we receive it. Confirmed by @codebytere at gitify-app/gitify#501
0 comments bug · comments · notifications · API
|
2
votes
|
Wiki pages with colon in the title do not clone properly
by
This wiki was created 4 years ago so that might be the problem or possibly there is some malformed content within the pages. See screenshots of wiki pages sidebar and cloned result
8 comments bug · wiki · forks
|
2
votes
|
Commit with a huge number of parents 502s
by
The repo: https://github.com/cirosantilli/test-commit-many-parents-1m The 502: cirosantilli/test-commit-many-parents-1m@e57a199 Parent list should be paged / capped.
0 comments bug
|
1
votes
|
URL is parsed wrongly in Markdown
by
ShareX/ShareX@v13.4.0...master#files_bucket is not
1 comments bug
|
1
votes
|
Unhandled error presented when making a Commit while the file is still being uploaded in the platform.
by
Hi there, I'd like to raise this issue on Github when I upload files through the platform. When I go to "Add file" drop-down menu > Upload files" and upload a file, I see the progress bar showing the file is being uploaded, however the tool gives the option to "Commit change" while the file is still being uploaded, which takes me to a possible unhandled page error showing: When this issue happens, I also need to return to the previous page and upload the file again. I imagine that is not very common for people do this in the platform but I'd like to suggest that the "Commit changes" button get disabled while the upload is still occurring, and enable only after the upload is complete to avoid this issue. Thanks
0 comments bug · ui · file-view · workflow
|
1
votes
|
searching only issues (without PRs)
by
I want to search only issues (normal issues, not PRs) for a given repo or organization. Unfortunately So I don't know which query I should type and whether it's possible.
6 comments bug · issues · pull-requests · search
|
1
votes
|
Symbol when a PR is closed is not centered
by
2 comments bug · pull-requests
|
1
votes
|
.editorconfig doesn't work on mobile
by
See title
4 comments bug · file-view · mobile
|
1
votes
|
(Markdown) Nested ordered 0-indexed lists render incorrectly
by
This is most easily demonstrated by viewing the "rich diff" of a commit that works around this bug by switching to 1-indexing: OctoLinker/OctoLinker@9b2119b?short_path=6a33714#diff-6a3371457528722a734f3c51d9238c13 The source diff shows the unrendered changes: OctoLinker/OctoLinker@9b2119b#diff-6a3371457528722a734f3c51d9238c13
0 comments bug · diff
|
1
votes
|
The type of some parameters in developer.github.com/v3/git/refs/#create-a-reference is "type" instead of "string"
by
https://developer.github.com/v3/git/refs/#create-a-reference Look in the parameters type. The type of some parameters is I am also currently testing if there is a technical issue with this API call.
3 comments bug · documentation
|
1
votes
|
Couldn't push temporaly to a repository
by
Working in a repository "git push origin master" didn't work once, some seconds later it worked. $ git push origin master $ git remote -v $ date (this error happened like 5 minutes ago).
2 comments bug
|
1
votes
|
web-based diff shows a different diff than cmd-line git output...
by
I came across a potential bug of the web-based diff tool in github where for one specific diff the web-based diff tool somehow shows something completely different (in fact a NOP) than using the cmd-line "git diff" which actually should be the gold standard. See here: Using cmd-line "git diff" for this commit show the following diff, however:
3 comments bug · diff
|
1
votes
|
Inconsistent search query UI for hex numbers shows no matches instead of invalid search
by
0 comments bug · search · ui
|
1
votes
|
Autolinks with angle brackets whose URLs contain single or double quotes don't show in rendered markdown files and issues
by
E.g.:
renders to nothing: but I'd expect a link instead. Further tests: https://github.com/cirosantilli/test-git-web-interface/blob/504d212433cea225871d3e6251fbdf323747cf58/md.md#link || wayback machine I think those are all valid URLs: http://stackoverflow.com/a/25570235/895245 All work on CommonMark 0.21: http://spec.commonmark.org/dingus/ This came from a real-life application: http://wiki.osdev.org/James_Molloy's_Tutorial_Known_Bugs
2 comments bug · markdown
|
0
votes
|
Unicorn! - GitHub cannot search username in organization that have a lot of members
by
DescriptionCurrently, I can't search any username (including mine) in organization that have a lot of members. For instance, in the EpicGames organization, it will show you no result if you search based on the username. And if you force accessing via url with query param (https://github.com/orgs/EpicGames/people?query=ezralazuardy), it will give you an 🦄 error. FYI, This issue actually have been reported here but there is no further bug fix. Steps to Reproduce
5 comments bug · search · unicorns 🦄
|
0
votes
|
Sorting issues fails for large number
by
I am using following url for retrieving issues : https://api.github.com/repos/owner/repo_name/issues?state=open&direction=asc&page=0
0 comments bug · issues · sorting
|
0
votes
|
Upgrade to latest SortableJS
by
If you go into the Projects section of a repository and try to drag and drop the columns, the native drag and drop in Google Chrome may cause the drag image to contain extra unnecessary elements. This has been solved in SortableJS as of version 1.8.1. After looking at the source, I believe Github is using an older version of Sortable for this feature. Here is how this issue may be reproduced:
0 comments bug · projects
|
0
votes
|
Incorrect timing on comment notifications
by
On my GitHub homepage, I see this: "Commented" is not the proper summary to report for the event "comment was marked as spam."
1 comments bug · enhancement · notifications
|
0
votes
|
GitHub Check Run two statuses showing
by
I'm developing a GitHub App that uses the GitHub Checks API, and I think I might have found a bug: I originally create the check run as "completed/neutral", and then I mark it as "in_progress", but it seems like both statuses are shown in the UI. Looking at the HTML, it seems like there should be some logic that actually checks if
7 comments bug · API
|
0
votes
|
sync problem with file with lower case and upper case
by
Hello,
13 comments bug · file-view · github-desktop
|
0
votes
|
Off-by-one number of stars
by
https://github.com/opennota shows 888 stars, but at https://github.com/stars I see 889 of them.
0 comments bug · starred-repo-list
|
0
votes
|
Multiple quotes in a row are rendered as one in Markdown pages
by
Text sample:
Inside "Preview" tab everything works as expected, each quote is rendered separately: However, in the actual page we get one quote with merged contents:
3 comments bug · markdown
|
0
votes
|
Clicking "tab" in the index page of GitHub focuses on "skip to content" on upper left corner of page
by
In the index page 'github.com' , when I click Tab button , there is a 'a tag' on the left & the content is 'skip to content' .
2 comments bug · ui
|
0
votes
|
"Resolve conflicts" button on PRs 404s
by
A PR I sent - prism-break/prism-break#1627 - has some merge conflicts. In the GitHub web interface I see a "Resolve conflicts" button at the bottom (in the place where the green "Merge" button would appear). However, clicking this button takes me to https://github.com/nylira/prism-break/pull/1627/conflicts, which 404s. Note that I have no write access whatsoever to the repository in question.
2 comments bug
|
0
votes
|
Watchers page format is a mess
by
User info is getting bumped into the next line and into user's icons. Makes it unreadable and visually unappealing. Example of this behavior shown below.
2 comments bug · ui
|
0
votes
|
BUG: Collaborator label now missing from comments of collaborators of organizations
by
It used to be the case that comments made by collaborators on issues and pull requests received a label or badge that indicated they were collaborators similar to owners/members. However, this appears to have been removed. This occurred at the same time owners were renamed to members so may have been a regression that slipped into that change. I have raised this with GitHub Support via email and recommend anyone interested in this does the same. Currently, they are looking into it.
8 comments bug · comments · ui
|
0
votes
|
[Bug] Renaming an organization breaks custom GitHub Pages domains
by
Steps to reproduce:
Note that forcing a Pages rebuild fixed this issue.
1 comments bug · pages
|
0
votes
|
whenever I want to smile real big, GitHub wants me to dance instead
by
7 comments bug · emoji
|